[Qemu-devel] [5966] Fix off-by-one bug limiting VNC passwords to 7 chars (Chris Webb)

[Anthony Liguori]

Revision: 5966
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5966
Author:   aliguori
Date:     2008-12-10 15:12:57 +0000 (Wed, 10 Dec 2008)

Log Message:
-----------
Fix off-by-one bug limiting VNC passwords to 7 chars (Chris Webb)

monitor_readline expects buf_size to include the terminating \0, but
do_change_vnc in monitor.c calls it as though it doesn't. The other site
where monitor_readline reads a password (in vl.c) passes the buffer 
length
correctly.

Signed-off-by: Chris Webb <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

Modified Paths:
--------------
    trunk/monitor.c

Modified: trunk/monitor.c
===================================================================
--- trunk/monitor.c     2008-12-10 15:02:33 UTC (rev 5965)
+++ trunk/monitor.c     2008-12-10 15:12:57 UTC (rev 5966)
@@ -434,8 +434,7 @@
     if (strcmp(target, "passwd") == 0 ||
        strcmp(target, "password") == 0) {
        char password[9];
-       monitor_readline("Password: ", 1, password, sizeof(password)-1);
-       password[sizeof(password)-1] = '\0';
+       monitor_readline("Password: ", 1, password, sizeof(password));
        if (vnc_display_password(NULL, password) < 0)
            term_printf("could not set VNC server password\n");
     } else {