Re: [Qemu-devel] [5860] Cleanup {alloc|get}_cluster_offset() (Gleb Natapov)

[Gleb Natapov]

On Thu, Dec 11, 2008 at 04:16:04PM +0100, Alexander Graf wrote:
> Gleb Natapov wrote:
> > On Wed, Dec 10, 2008 at 08:38:19AM -0600, Anthony Liguori wrote:
> >   
> >> Hi Gleb,
> >>
> >> Anthony Liguori wrote:
> >>     
> >>> Revision: 5860
> >>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5860
> >>> Author:   aliguori
> >>> Date:     2008-12-02 20:11:27 +0000 (Tue, 02 Dec 2008)
> >>>   
> >>>       
> >> According to https://bugzilla.novell.com/show_bug.cgi?id=457957, this  
> >> changeset breaks compressed qcow2 on write and savevm.
> >>
> >> Can you please look into this?
> >>
> >>     
> > Alexander, can you try the patch below?
> >   
> 
> The patch seems to work just fine. Please also take a look at Kevin's
> and see which one fits best. Since I'm not really into qcow2 code, I
> can't tell which one  is the more accurate one.
> 
> Thanks a lot for looking so quickly into this!
> 
I considered initially something like Kevin solution. I think mine
fix is better for code readability reasons.

--
                        Gleb.