qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [6009] Fix smsw for x86_64 guest and bigendian host cas


From: malc
Subject: Re: [Qemu-devel] [6009] Fix smsw for x86_64 guest and bigendian host case
Date: Sat, 13 Dec 2008 23:16:37 +0300 (MSK)

On Sat, 13 Dec 2008, Stuart Brady wrote:

On Sat, Dec 13, 2008 at 03:51:14PM +0000, malc wrote:
+#if defined TARGET_X86_64 && defined WORDS_BIGENDIAN
+            tcg_gen_ld32u_tl(cpu_T[0], cpu_env, offsetof(CPUX86State,cr[0]) + 
4);
+#else
             tcg_gen_ld32u_tl(cpu_T[0], cpu_env, offsetof(CPUX86State,cr[0]));
+#endif

Hmm -- shouldn't REG_L_OFFSET be added instead of using #ifdefs?

Probably not. This mixes GPRs with CRs, that said the core idea is sound.

--
mailto:address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]