[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1 of 4] kvm-userpace: add virtio-console support
From: |
Mark McLoughlin |
Subject: |
Re: [Qemu-devel] [PATCH 1 of 4] kvm-userpace: add virtio-console support |
Date: |
Mon, 19 Jan 2009 10:09:40 +0000 |
On Tue, 2009-01-13 at 16:37 +0100, Christian Ehrhardt wrote:
> + virtio_consoles[0] = "vc:80Cx24C";
> + for(i = 1; i < MAX_VIRTIO_CONSOLES; i++)
> + virtio_consoles[i] = NULL;
> + virtio_console_index = 0;
Hmm, why do we have virtio console enabled by default on x86? Does it
make sense for it to only be available if it's explicitly configured,
except for platforms that don't have serial?
There's a good chance this is going to confuse the hell out of Fedora's
installer, for example. And how does the likes of "virsh console" know
to connect to the virtio console rather than the serial console?
Cheers,
Mark.
- [Qemu-devel] [PATCH 0 of 4] Add virtio-console support to qemu, Christian Ehrhardt, 2009/01/13
- [Qemu-devel] [PATCH 1 of 4] kvm-userpace: add virtio-console support, Christian Ehrhardt, 2009/01/13
- [Qemu-devel] [PATCH 3 of 4] kvm-userpace: add virtio-console initializer for x86, Christian Ehrhardt, 2009/01/13
- [Qemu-devel] [PATCH 4 of 4] kvm-userpace: add virtio-console initializer for powerpc, Christian Ehrhardt, 2009/01/13
- [Qemu-devel] [PATCH 2 of 4] kvm-userpace: add virtio-console cmdline option, Christian Ehrhardt, 2009/01/13
- Re: [Qemu-devel] [PATCH 0 of 4] Add virtio-console support to qemu, Avi Kivity, 2009/01/13
- Re: [Qemu-devel] [PATCH 0 of 4] Add virtio-console support to qemu, Christian Borntraeger, 2009/01/13