[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option - revised
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option - revised |
Date: |
Wed, 21 Jan 2009 18:23:52 +0000 |
User-agent: |
Mutt/1.4.1i |
On Wed, Jan 21, 2009 at 01:07:51PM -0500, Trolle Selander wrote:
> Hi all,
>
> This is an updated version of the patch after the suggestions/discussion
> on the list. It also includes different handling of how the -vga option
> is handled internally, replacing the multiple
> independent-yet-mutually-exclusive xxx_vga_enabled variables with one
> vgahw_model variable, and also includes the -vga none option added by
> Stefano in the time since my last version of this patch. Further
> comments & testing welcome. :)
> @@ -4933,6 +4930,13 @@
> case QEMU_OPTION_vga:
> select_vgahw (optarg);
> break;
> + case QEMU_OPTION_videoram:
> + {
> + char *ptr;
> + vga_ram_size = strtol(optarg,&ptr,10);
> + vga_ram_size *= 1024 * 1024;
> + }
> + break;
> case QEMU_OPTION_g:
> {
> const char *p;
Rather than adding more add hoc extra parameters for VGA tunables, we
should just make -vga work like the other generic device args, accepting
a optional list comma separated values following it
eg
-vga cirrus,ram=32
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option, Avi Kivity, 2009/01/11
- Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option, Trolle Selander, 2009/01/12
- Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option, Paul Brook, 2009/01/14
- Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option, Trolle Selander, 2009/01/14
- Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option, Paul Brook, 2009/01/14
- Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option, Trolle Selander, 2009/01/14
- Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option, Jamie Lokier, 2009/01/15
- Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option, Rene Rebe, 2009/01/15
- Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option, Jamie Lokier, 2009/01/15