Re: [Qemu-devel] [PATCH 07/14] Add v{add,sub}fp instructions

[Aurelien Jarno]

On Sun, Feb 08, 2009 at 02:39:04PM -0800, Nathan Froyd wrote:
> We don't need to split up vaddfp and vsubfp because the softfloat code
> already properly handles magnitude subtraction of infinities.
> 
> Signed-off-by: Nathan Froyd <address@hidden>
> ---
>  target-ppc/helper.h    |    2 ++
>  target-ppc/op_helper.c |   14 ++++++++++++++
>  target-ppc/translate.c |    2 ++
>  3 files changed, 18 insertions(+), 0 deletions(-)

Thanks, applied.

> diff --git a/target-ppc/helper.h b/target-ppc/helper.h
> index 1c76586..43d1867 100644
> --- a/target-ppc/helper.h
> +++ b/target-ppc/helper.h
> @@ -232,6 +232,8 @@ DEF_HELPER_3(vsum2sws, void, avr, avr, avr)
>  DEF_HELPER_3(vsum4sbs, void, avr, avr, avr)
>  DEF_HELPER_3(vsum4shs, void, avr, avr, avr)
>  DEF_HELPER_3(vsum4ubs, void, avr, avr, avr)
> +DEF_HELPER_3(vaddfp, void, avr, avr, avr)
> +DEF_HELPER_3(vsubfp, void, avr, avr, avr)
>  DEF_HELPER_3(vmaxfp, void, avr, avr, avr)
>  DEF_HELPER_3(vminfp, void, avr, avr, avr)
>  DEF_HELPER_2(vlogefp, void, avr, avr)
> diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c
> index 674a21d..6cf47a3 100644
> --- a/target-ppc/op_helper.c
> +++ b/target-ppc/op_helper.c
> @@ -2099,6 +2099,20 @@ VARITH(uwm, u32)
>  #undef VARITH_DO
>  #undef VARITH
>  
> +#define VARITHFP(suffix, func)                                          \
> +    void helper_v##suffix (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)    \
> +    {                                                                   \
> +        int i;                                                          \
> +        for (i = 0; i < ARRAY_SIZE(r->f); i++) {                        \
> +            HANDLE_NAN2(r->f[i], a->f[i], b->f[i]) {                    \
> +                r->f[i] = func(a->f[i], b->f[i], &env->vec_status);     \
> +            }                                                           \
> +        }                                                               \
> +    }
> +VARITHFP(addfp, float32_add)
> +VARITHFP(subfp, float32_sub)
> +#undef VARITHFP
> +
>  #define VARITHSAT_CASE(type, op, cvt, element)                          \
>      {                                                                   \
>          type result = (type)a->element[i] op (type)b->element[i];       \
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 1f6386b..af83b19 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -6395,6 +6395,8 @@ GEN_VXFORM(vsum4sbs, 4, 28);
>  GEN_VXFORM(vsum4shs, 4, 25);
>  GEN_VXFORM(vsum2sws, 4, 26);
>  GEN_VXFORM(vsumsws, 4, 30);
> +GEN_VXFORM(vaddfp, 5, 0);
> +GEN_VXFORM(vsubfp, 5, 1);
>  GEN_VXFORM(vmaxfp, 5, 16);
>  GEN_VXFORM(vminfp, 5, 17);
>  
> -- 
> 1.6.0.5
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net