Re: [Qemu-devel] [PATCH] Fix incorrect attempt to clear a flag in vnc.c

[Brian Kress]

Anthony Liguori wrote:
> Brian Kress wrote:
> > In vnc.c in pixel_format_message, the code tries to clear the 
> > QEMU_ALLOCATED_FLAG
> > from the client display surface, however it uses the wrong operator 
> > and ends up enabling all
> > other flags.  Most notably this enables the big endian flag and 
> > causes some chaos.
> Can you add a Signed-off-by line?
Signed-off-by: Brian Kress <address@hidden>

Index: vnc.c
===================================================================
--- vnc.c       (revision 6619)
+++ vnc.c       (working copy)
@@ -1421,7 +1421,7 @@
    else if (vs->ds->surface->pf.bits_per_pixel == 8)
        vs->send_hextile_tile = send_hextile_tile_8;
    vs->clientds = *(vs->ds->surface);
-    vs->clientds.flags |= ~QEMU_ALLOCATED_FLAG;
+    vs->clientds.flags &= ~QEMU_ALLOCATED_FLAG;
    vs->write_pixels = vnc_write_pixels_copy;

    vnc_write(vs, pad, 3);           /* padding */