Re: [Qemu-devel] [PATCH] Revert block-qcow2.c to kvm-72 version due to corruption reports

[Anthony Liguori]

Jamie Lokier wrote:
> Anthony Liguori wrote:
>   
> > On Sat, Feb 14, 2009 at 8:01 PM, Jamie Lokier <address@hidden> wrote:
> >     
> > > Have done, did you read the other thread?
> > >       
> > Yes, but your patch confused me (which is admittedly not hard).
> >
> >     
> > > > It's QEMU SVN delta 5005-5006, copied below.
> > > >         
> > So why such an aggressive revert?  Why not just revert the problematic
> > changesets?
> >     
>
> Because most of the following changes look too dependent on it.
>   

Too dependent on the introduced functionality or too dependent to make 
porting trivial?  My impression upon looking was that it's the later, 
not the former.  If that is the case, then someone needs to do the work 
of properly reverting.

> I did keep a couple of changes which are trivially independent since
> that one - default to "cache=writeback" and eliminating #define
> offsetof.
>
> You have a point that QEMU SVN deltas up to 5005 don't need to be
> reverted.  Reason for that: I simply don't have time to trim the patch
> down to its bare essentials quickly, and being a corruption bug, it
> should be dealt with quickly.  This one seems to work; feel free to
> improve it by reverting less, or waiting a long time for me to do so :-)
>   

But many of the changes since 5005 were also corruption fixes.  And 
let's be clear, your data is *not* safe with qcow2.  So I don't consider 
this to be a show stopping issue.

Regards,

Anthony Liguori

> -- Jamie
>
>
>