[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's
From: |
Liu Yu-B13201 |
Subject: |
RE: [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support |
Date: |
Wed, 18 Feb 2009 14:04:31 +0800 |
> -----Original Message-----
> From: address@hidden
> [mailto:address@hidden On Behalf Of Blue Swirl
> Sent: Tuesday, February 17, 2009 11:09 PM
> To: address@hidden
> Cc: address@hidden; address@hidden; Liu Yu-B13201;
> address@hidden
> Subject: Re: [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add
> freescale pci controller's support
>
> On 2/17/09, Liu Yu <address@hidden> wrote:
> > This patch add the emulation of freescale's pci controller
> for E500 platform.
> >
> > Signed-off-by: Liu Yu <address@hidden>
>
> A reset function (registered with qemu_register_reset) would be nice.
>
> > + * Copyright (C) 2009 Freescale Semiconductor, Inc. All
> rights reserved.
>
> "All rights reserved" conflicts with GPL.
It's our company's policy, all the patches submitted to kernel comply with this
as well.
>
> > + d->config[0x00] = 0x57; // vendor_id
> > + d->config[0x01] = 0x19;
> > + d->config[0x02] = 0x30; // device_id
> > + d->config[0x03] = 0x00;
>
> Please use pci_config_set_vendor_id and pci_config_set_device_id
> functions and add the ID #defines to hw/pci.h.
Fixed.
>
> > + d->config[0x0a] = 0x20; // class_sub = other bridge type
> > + d->config[0x0b] = 0x0B; // class_base = PCI_bridge
>
> I'd think these should be 0x06 (PCI_BASE_CLASS_BRIDGE) and 0x04
> (PCI_CLASS_BRIDGE_PCI). Are these correct?
Sorry for the wrong comments.
I confirmed it from user manual, and I also print the header out on MPC8544
board.
it shows that these value are correct.
0x20 represent PowerPC and 0x0B represent processor.
Like "#define PCI_CLASS_PROCESSOR_CO 0x0b40" in hw/pci.h
- [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support, (continued)
- [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support, Liu Yu, 2009/02/17
- [Qemu-devel] [PATCH 3/5] kvm/powerpc: Add irq support for E500 core, Liu Yu, 2009/02/17
- [Qemu-devel] [PATCH 4/5] kvm/powerpc: Add MPC8544DS board support, Liu Yu, 2009/02/17
- [Qemu-devel] [PATCH 5/5] kvm/powerpc: flat device tree files for MPC8544DS, Liu Yu, 2009/02/17
- Re: [Qemu-devel] [PATCH 4/5] kvm/powerpc: Add MPC8544DS board support, Blue Swirl, 2009/02/17
- RE: [Qemu-devel] [PATCH 4/5] kvm/powerpc: Add MPC8544DS board support, Liu Yu-B13201, 2009/02/18
- Re: [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support, Blue Swirl, 2009/02/17
- Re: [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support, M. Warner Losh, 2009/02/17
- Re: [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support, M. Warner Losh, 2009/02/17
- Re: [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support, Jamie Lokier, 2009/02/17
- RE: [Qemu-devel] [PATCH 2/5] kvm/powerpc: Add freescale pci controller's support,
Liu Yu-B13201 <=
Re: [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform., Blue Swirl, 2009/02/17
Re: [Qemu-devel] [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform., Paulev, 2009/02/19