[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix some compiler warnings for windows
From: |
malc |
Subject: |
Re: [Qemu-devel] [PATCH] Fix some compiler warnings for windows |
Date: |
Sun, 1 Mar 2009 15:00:01 +0300 (MSK) |
On Sun, 1 Mar 2009, Stefan Weil wrote:
> Stefan Weil schrieb:
> > Hello,
> >
> > this patch fixes some warnings for compilation with mingw32.
> >
> > Regards
> > Stefan Weil
>
> Here is an update of my patch for the current Qemu trunk.
> It reduces the number of warnings for win32 from 256 to 67.
>
> At least one warning indicates an error in Qemu for Windows:
> vl.c:5386: warning: fds[1] is used uninitialized in this function
> This was fixed, too.
>
> Could one of the maintainers please apply this patch to Qemu trunk?
Index: trunk/block-raw-win32.c
===================================================================
--- trunk.orig/block-raw-win32.c 2009-03-01 11:04:03.000000000
+0100
+++ trunk/block-raw-win32.c 2009-03-01 11:04:10.000000000 +0100
@@ -279,7 +279,7 @@
static int raw_truncate(BlockDriverState *bs, int64_t offset)
{
BDRVRawState *s = bs->opaque;
- DWORD low, high;
+ LONG low, high;
low = offset;
high = offset >> 32;
@@ -301,7 +301,8 @@
switch(s->type) {
case FTYPE_FILE:
- l.LowPart = GetFileSize(s->hfile, &l.HighPart);
+ l.LowPart = GetFileSize(s->hfile, &count);
+ l.HighPart = count;
if (l.LowPart == 0xffffffffUL && GetLastError() != NO_ERROR)
return -EIO;
break;
[..snip..]
http://msdn.microsoft.com/en-us/library/aa364955(VS.85).aspx
DWORD WINAPI GetFileSize(
__in HANDLE hFile,
__out_opt LPDWORD lpFileSizeHigh
);
IOW LONG doesn't seem to be correct.
--
mailto:address@hidden