[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: Re : Re: patch: (attempt to) emulate 440BX/PIIX4
From: |
Andriy Gapon |
Subject: |
[Qemu-devel] Re: Re : Re: patch: (attempt to) emulate 440BX/PIIX4 |
Date: |
Thu, 19 Mar 2009 16:56:55 +0200 |
User-agent: |
Thunderbird 2.0.0.19 (X11/20090110) |
on 18/03/2009 18:12 Sylvain Petreolle said the following:
>
> This part should should change piix3_devfn to piix4_devfn IMHO.
>
> --- hw/pc.c.orig 2009-03-04 22:54:45.000000000 +0000
> +++ hw/pc.c 2009-03-17 07:47:58.120091474 +0000
> @@ -938,7 +941,7 @@
>
> if (pci_enabled) {
> pci_bus = i440fx_init(&i440fx_state, i8259);
> - piix3_devfn = piix3_init(pci_bus, -1);
> + piix3_devfn = piix4_init(pci_bus, 7 << 3);
> Kind regards,
Yes, this would be correct from code self-descriptiveness point of view and it
must be done. I just wanted to initially produce a minimalistic obvious patch,
so
that people could review and comment.
--
Andriy Gapon