qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [6944] fix format string warnings in block-qcow2.c (Christo


From: Anthony Liguori
Subject: [Qemu-devel] [6944] fix format string warnings in block-qcow2.c (Christoph Hellwig)
Date: Sun, 29 Mar 2009 01:31:56 +0000

Revision: 6944
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6944
Author:   aliguori
Date:     2009-03-29 01:31:56 +0000 (Sun, 29 Mar 2009)
Log Message:
-----------
fix format string warnings in block-qcow2.c (Christoph Hellwig)

Recent patches added two compiler warnings about the format string
usage in qcow_read_extensions.  One is printing a uint64_t using
%lu which is incorrect on many platforms as it can be a unsigned
long long, the second one is printing the result of sizeof as
%lu, but it is a size_t so it needs to be printed using %zu.


Signed-off-by: Christoph Hellwig <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>

Modified Paths:
--------------
    trunk/block-qcow2.c

Modified: trunk/block-qcow2.c
===================================================================
--- trunk/block-qcow2.c 2009-03-29 01:31:51 UTC (rev 6943)
+++ trunk/block-qcow2.c 2009-03-29 01:31:56 UTC (rev 6944)
@@ -223,8 +223,8 @@
 #endif
 
         if (bdrv_pread(s->hd, offset, &ext, sizeof(ext)) != sizeof(ext)) {
-            fprintf(stderr, "qcow_handle_extension: ERROR: pread fail from 
offset %lu\n",
-                    offset);
+            fprintf(stderr, "qcow_handle_extension: ERROR: pread fail from 
offset %llu\n",
+                    (unsigned long long)offset);
             return 1;
         }
         be32_to_cpus(&ext.magic);
@@ -240,7 +240,7 @@
         case QCOW_EXT_MAGIC_BACKING_FORMAT:
             if (ext.len >= sizeof(bs->backing_format)) {
                 fprintf(stderr, "ERROR: ext_backing_format: len=%u too large"
-                        " (>=%lu)\n",
+                        " (>=%zu)\n",
                         ext.len, sizeof(bs->backing_format));
                 return 2;
             }





reply via email to

[Prev in Thread] Current Thread [Next in Thread]