[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC] Introduce module API to QEMU

From: Anthony Liguori
Subject: Re: [Qemu-devel] [RFC] Introduce module API to QEMU
Date: Fri, 03 Apr 2009 12:36:42 -0500
User-agent: Thunderbird (X11/20090320)

Mark McLoughlin wrote:

Generally looks good to me.

On Thu, 2009-04-02 at 21:12 -0500, Anthony Liguori wrote:
diff --git a/hw/mcf_fec.c b/hw/mcf_fec.c
index 413c569..49ae69b 100644
--- a/hw/mcf_fec.c
+++ b/hw/mcf_fec.c
@@ -446,8 +446,6 @@ void mcf_fec_init(NICInfo *nd, target_phys_addr_t base, 
qemu_irq *irq)
     mcf_fec_state *s;
     int iomemtype;
- qemu_check_nic_model(nd, "mcf_fec");

It's obscure, but this line does three things:

  1) Makes 'qemu-system-m68k -net nic,model=?' list the available model

  2) Makes 'qemu-system-m68k -net nic,model=e1000' fail

3) Makes 'qemu-system-m68k -net nic' have sane 'info network' output - i.e. the model is listed as mcf_fec

After looking at it, I'm inclined to just ignore these issues. For the targets where this matters, you cannot specify anything other than the default nic models. They all hard code what nics are available and just use the number of nics to determine whether to support multiple of those nics.


Anthony Liguori

That goes for the other non-PCI NICs too.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]