[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] SH: support 7785 serial

From: Shin-ichiro KAWASAKI
Subject: Re: [Qemu-devel] SH: support 7785 serial
Date: Mon, 06 Apr 2009 22:15:16 +0900
User-agent: Thunderbird (Windows/20090302)

Hi, Vladimir.
Thank you for your work.

Vladimir Prus wrote:
These 3 patches make sh_serial.c support 7785 serial. The primary
difference is that on 7785, instead of single fifo count register
there are two separate ones -- for rx and tx. Patch 3 adds necessary
conditional logic. Patches 1 and 2 are cleanups that I've done alone
the way:

- Patch 1 makes it possible to change the size of RX fifo. It's 16
on 7751 and 64 on 7785. While I do not know of any breakage if we
use wrong size, it's still best to be correct.
- Patch 2 replaces a pile of hardcoded constants with macroses.
Also, the FSR register was handled strangely -- when written, we'd
look at the written value and set bits in the 'flags' field, and on
read, we'd reconstruct the value from the 'flags' field. There does
not seem to be any reason for such roundabout, so I've made the code
work with 'sr' directly.

This patch was tested both with r2d, using kernel and userland found


and with 7785, using a hand-made kernel.

Patch 2 produces a trouble in my environment.
For r2d, the output to SCIF from kernel is OK, but output from
shell is broken by inserted white space, like follows.

(before applying patch 2)
# ls

(after applying patch2)
# l s
Do you have time to investigate it?

Shin-ichiro KAWASAKI

reply via email to

[Prev in Thread] Current Thread [Next in Thread]