[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] xen: add block device backend driver.
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 05/10] xen: add block device backend driver. |
Date: |
Tue, 7 Apr 2009 17:51:44 +0200 |
User-agent: |
Mutt/1.3.28i |
On Tue, Apr 07, 2009 at 12:22:00PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >We already have bdrv_aio_readv/writev which currently linearize the
> >buffer underneath. Hopefully Anthony will have commited the patch to
> >implement the real one while I'm writing this, too :)
>
> Is there any specific reason to keep the nb_sectors argument for
> bdrv_aio_readv, other than cut&paste from the non-vectored versions?
> I think it is superfluous now, it can be trivially calculated using
> iov->size.
For the functions in block.c I want to keep them the same as they were
before, and for the methods I want to keep the signature the same as
the exported wrappers.
All this is going to change pretty soon I hope, we'll need another
argument to bdrv_aio_write for barrier writes, and I might switch to
a completely byte based interface for the aio requests with flags
in the block driver state for flagging the alignment restrictions.
- [Qemu-devel] [PATCH 06/10] xen: add net backend driver., (continued)
Re: [Qemu-devel] [PATCH 00/10] xen: pv domain support., Anthony Liguori, 2009/04/01
Re: [Qemu-devel] [PATCH 00/10] xen: pv domain support., Laurent Vivier, 2009/04/02
- Re: [Qemu-devel] [PATCH 00/10] xen: pv domain support., Gerd Hoffmann, 2009/04/03
- Re: [Qemu-devel] [PATCH 00/10] xen: pv domain support., Alexander Graf, 2009/04/03
- Re: [Qemu-devel] [PATCH 00/10] xen: pv domain support., Avi Kivity, 2009/04/05
- Re: [Qemu-devel] [PATCH 00/10] xen: pv domain support., Alexander Graf, 2009/04/05
- Re: [Qemu-devel] [PATCH 00/10] xen: pv domain support., Avi Kivity, 2009/04/05
- Re: [Qemu-devel] [PATCH 00/10] xen: pv domain support., Alexander Graf, 2009/04/05
- Re: [Qemu-devel] [PATCH 00/10] xen: pv domain support., Avi Kivity, 2009/04/05