[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount()

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 1/5] qcow2: Fix warnings in check_refcount()
Date: Fri, 17 Apr 2009 16:03:42 -0500
User-agent: Thunderbird (X11/20090320)

Kevin Wolf wrote:
Hi Anthony,

Am Freitag, 17. April 2009 22:39 schrieb Anthony Liguori:
Do you have a qemu-io script handy that can be used to stress something
like this patch set?  After the last qcow2 regression, I'm wary of
additional cleanups that we can't validate with a strong stress test.

This patch series is harmless in that respect. You can tell alone from looking at the patches that it can't cause regressions in normal operation, because it only touches code which was previosuly not even built and is only called by qemu-img (after patch 3) and when DEBUG_ALLOC is defined.

I'm basically at the point of not wanting to touch qcow2 without serious testing. That said, I can do enough on my own to satisfy me so I'll commit this series later today or tomorrow.

But you would better apply the corruption fix I sent on Wednesday. ;-)

Yes, I just checked that in.  Very good catch!

And even though I think that this series can't break anything, we definitely could use a strong test suite. I'm almost sure that there is at least one bug left (the one Jamie Lokier saw from 5006 on, but nobody ever found it).

You don't think that was Nolan's fix?



Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]