[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting

From: Blue Swirl
Subject: Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches
Date: Mon, 20 Apr 2009 18:29:11 +0300

On 4/20/09, Anthony Liguori <address@hidden> wrote:
> Blue Swirl wrote:
> > Hi,
> >
> > I gathered a few common complaints about patch submission, hopefully
> > not too much affected by my consumption of small amounts of various
> > alcoholic substances.
> >
> > Comments, objections?
> >
> >
> > +SP4.1: It must be possible to apply the patch with quilt (equivalent
> > +to patch -p1) and "git am" without any editing or extra flags
> >
>  svn diff generates -p0 patches so both -p1 and -p0 should be accepted.

Quilt does not accept -p0 patches without extra work. Remember, the
idea is to reduce our burden, make it easier to test and apply

Diff can generate other types of diffs besides the unified type but we
don't want any other.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]