[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/4] v2: add NUMA emulation

From: Andre Przywara
Subject: [Qemu-devel] Re: [PATCH 0/4] v2: add NUMA emulation
Date: Tue, 21 Apr 2009 12:26:25 +0200
User-agent: Thunderbird (X11/20080508)

Anthony Liguori wrote:
Hi Andre,

I don't understand why it's so difficult to eliminate the 64 CPU limit.
Because bitmap operations are not trivial to be done right (look at Linux' implementation). I will send a patch later (introducing generic bitmap operations), but I didn't want to merge this with the NUMA patchset.

I'm willing to take these patches with the limit but I'd like to see the following:

The -numa stuff needs to be more defensive when -smp > 64. Specificially, it needs to explicitly check and warn the user if a NUMA node contains a CPU > 64.
OK, done.

Each patch needs some description of what it's doing. All patches need a SoB.
Agreed. But git should have already added a SoB line for every patch, no?


Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448 3567 12
----to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Jochen Polster; Thomas M. McCoy; Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

reply via email to

[Prev in Thread] Current Thread [Next in Thread]