[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix utimensat (aka unbreak cp -a)
|
From: |
Jamie Lokier |
|
Subject: |
Re: [Qemu-devel] [PATCH] Fix utimensat (aka unbreak cp -a) |
|
Date: |
Tue, 21 Apr 2009 15:42:14 +0100 |
|
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Riku Voipio wrote:
> Soo.. glibc uses utimensat to implement futimens, but doesn't allow
> applications to use utimensat in the same way. What a mess.
It protects against apps passing in NULL path due to a bug and
touching the directory by accident. A minor bit of protection indeed.
> But if we are to go towards using libc calls, your patch is a step
> backwards. In case pathname is null, we can use futimens.
I agree, good idea.
-- Jamie