[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Change RTC time drift IRQ re-injection
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] [PATCH v2] Change RTC time drift IRQ re-injection |
Date: |
Wed, 22 Apr 2009 23:28:11 +0300 |
On Wed, Apr 22, 2009 at 03:23:46PM -0500, Anthony Liguori wrote:
> Gleb Natapov wrote:
>> Currently IRQ are reinjected as soon as they are acknowledged to
>> the RTC, but Windows sometimes do acknowledgement in a loop with
>> global interrupt disabled waiting for interrupt to be cleared and
>> it does not mask RTC vector in PIC/APIC while doing this. In such
>> situation interrupt injection always fails and RTC interrupt is never
>> cleared.
>>
>> Instead of reinjecting coalesced IRQs on acknowledgement the patch below
>> reinjects them by accelerating RTC clock a bit. This way RTC interrupt
>> is not constantly raced after coalesced interrupt.
>>
>> Signed-off-by: Gleb Natapov <address@hidden>
>>
>
> Applied, but...
>
>> @@ -536,6 +563,7 @@ static int rtc_load_td(QEMUFile *f, void *opaque, int
>> version_id)
>> s->irq_coalesced = qemu_get_be32(f);
>> s->period = qemu_get_be32(f);
>> + rtc_coalesced_timer_update(s)
>> return 0;
>> }
>> #endif
> You were missing a ';'. I added it.
>
Wow :(. I compiled it and even tested. Honestly! Something on the
internet eats semicolons.
--
Gleb.