[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup()

From: Paul Brook
Subject: Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup()
Date: Tue, 28 Apr 2009 13:08:25 +0100
User-agent: KMail/1.9.9

On Thursday 16 April 2009, Mark McLoughlin wrote:
> However, the way I see it is that the VLANClientState should "own" the
> PCIDevice, not the other way around - e.g. you want to free the device,
> you should do qemu_del_vlan_client(), rather than
> pci_device_unregister().

I disagree. This makes it impossible to have multiport devices.
The controlling entity should be the device, not the vlan interface.

This is related to some of the issues I've raised with the machine config 
patches. IMO it's important to consider how this kind of internat interaction 
should actually work, rather than blindly implementing whatever we currently 
expose to the user.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]