[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3
From: |
David Ahern |
Subject: |
Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3 |
Date: |
Fri, 01 May 2009 08:47:03 -0600 |
User-agent: |
Thunderbird 2.0.0.21 (X11/20090320) |
Anthony Liguori wrote:
> David Ahern wrote:
>> Did not see a response to the last version.
>>
>> This patch enables TCP keepalives on VNC connections and TCP-based char
>> devices.
>>
>> Default parameters have keep alive probes sent after 60-seconds of idle
>> time. Probes are sent every 12 seconds with the connection resetting
>> after 5 failed probes (ie., connection is closed if no response received
>> in 60-seconds).
>>
>> Changes v2 -> v3
>> Removed duplicate definition and fixed typo in comments.
>>
>> Signed-off-by: David Ahern <address@hidden>
>>
>>
>> david
>>
> This patch introduces a warning:
>
> /home/anthony/git/qemu/vnc.c:2039: warning: implicit declaration of
> function ‘enable_tcp_keepalive’
>
Missed that. Forgot to add net.h to vnc.c.
Before I re-send a patch, what's the feeling regarding enabling this all
the time versus a command line option to control it?
david
- Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3, (continued)
Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3, Anthony Liguori, 2009/05/01
- Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3,
David Ahern <=
- Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3, Anthony Liguori, 2009/05/01
- Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3, Paul Brook, 2009/05/01
- Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3, Anthony Liguori, 2009/05/01
- Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3, Paul Brook, 2009/05/01
- Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3, David Ahern, 2009/05/01