qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v2


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v2
Date: Wed, 06 May 2009 08:43:19 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Daniel P. Berrange wrote:
On Wed, May 06, 2009 at 08:12:56AM -0500, Anthony Liguori wrote:
Avi Kivity wrote:
Daniel P. Berrange wrote:
Then I'd prefer we add a protocol=XXX option for magic protocols. This would be easier to use & clearer than requiring escaping of magic characters, eg

  -drive file=/some/path:with:colons,protocol=file
  -drive file=http://some/path,protocol=uri

For compatability, we could make it such that if protocol=XXX was left out, it could try and "guess" it, in same way QEMU does if format=XXX is left out
for content format.
How about

-drive file=file:///some/path:with:colons?

Libvirt would use this unconditionally, command-line users can choose.
Why does libvirt care?  That confuses me.

I don't have any problem with QEMU supporting http, nbd, or other clever
file access schemes. I'll let others debate its merits vs using FUSE http filesystems :-)

All I care about from libvirt POV, is that there is a way to give QEMU an absolute file path for a disk, and guarentee that QEMU will treat this as
a local file path, and not try any access protocols, other than 'open(2)'.
Various options from this thread....

 - Treat any path starting with / as local file
 - Allow file:  as a prefix
 - Allow file:/// as a prefix, real URI style
 - Add a protocol=file  flag to -drive
The only viable solution is for libvirt to escape it's file names.

For instance, you're in all sorts of trouble if a user creates a filename that looks like 'My disk image,format=raw.img'

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]