[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 4/4] move apic functions to a separate apic.h he
From: |
Glauber Costa |
Subject: |
[Qemu-devel] Re: [PATCH 4/4] move apic functions to a separate apic.h header |
Date: |
Wed, 6 May 2009 13:08:00 -0300 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, May 06, 2009 at 05:52:04PM +0200, Jan Kiszka wrote:
> Glauber Costa wrote:
> > Later on, we'll want to call an apic function from helper.c.
> > The inclusion of pc.h, besides totally ugly, leads to a lot of
> > clashes.
> >
> > Signed-off-by: Glauber Costa <address@hidden>
> > ---
> > hw/apic.c | 1 +
> > hw/apic.h | 19 +++++++++++++++++++
> > hw/ioapic.c | 1 +
> > hw/mc146818rtc.c | 1 +
> > hw/pc.c | 1 +
> > hw/pc.h | 15 ---------------
> > 6 files changed, 23 insertions(+), 15 deletions(-)
> > create mode 100644 hw/apic.h
> >
> > diff --git a/hw/apic.c b/hw/apic.c
> > index d63d74b..72dbe88 100644
> > --- a/hw/apic.c
> > +++ b/hw/apic.c
> > @@ -19,6 +19,7 @@
> > */
> > #include "hw.h"
> > #include "pc.h"
> > +#include "apic.h"
>
> Does it still need pc.h then?
yes. For things like RTCState.
>
> > #include "qemu-timer.h"
> > #include "host-utils.h"
> >
> > diff --git a/hw/apic.h b/hw/apic.h
> > new file mode 100644
> > index 0000000..2437e9f
> > --- /dev/null
> > +++ b/hw/apic.h
> > @@ -0,0 +1,19 @@
> > +#ifndef _APIC_H_
> > +#define _APIC_H_
>
> "APIC_H", otherwise fine.
ok.
- [Qemu-devel] [PATCH 0/4] Simplify cpu initialization, Glauber Costa, 2009/05/06
- [Qemu-devel] Re: [PATCH 2/4] move CPUID_APIC flag to where it belongs, Jan Kiszka, 2009/05/06
- [Qemu-devel] Re: [PATCH 2/4] move CPUID_APIC flag to where it belongs, Glauber Costa, 2009/05/06
- RE: [Qemu-devel] Re: [PATCH 2/4] move CPUID_APIC flag to where it belongs, Stanislav, 2009/05/06
- Re: [Qemu-devel] Re: [PATCH 2/4] move CPUID_APIC flag to where it belongs, Glauber Costa, 2009/05/06
- RE: [Qemu-devel] Re: [PATCH 2/4] move CPUID_APIC flag to where it belongs, Stanislav, 2009/05/06
- Re: [Qemu-devel] Re: [PATCH 2/4] move CPUID_APIC flag to where it belongs, Anthony Liguori, 2009/05/06
[Qemu-devel] Re: [PATCH 1/4] move registering of cpu_reset to inside cpu_init, Jan Kiszka, 2009/05/06