Re: [Qemu-devel] [PATCH 0/3] linux-user: add ppc signal handling, v2

[malc]

On Tue, 12 May 2009, Nathan Froyd wrote:

> This patch series adds signal handling support for 32-bit PPC linux-user
> emulation.  It requires a bit of shuffling of target-ppc code to ensure
> that we know what the capabilities of our current CPU are so we know
> which registers to save.
> 
> The only change from the previous version, posted here:
> 
> http://lists.gnu.org/archive/html/qemu-devel/2009-04/index.html
> 
> is that the PT_* constants have been renamed to TARGET_PT_* constants so
> that everything will build OK on PowerPC Linux hosts.
> 
> The signal handling code has been tested by an in-house NPTL
> implementation for PPC linux-user emulation.  The NPTL implementation
> will be coming along shortly, but the signal handling bits are useful on
> their own.

This one works as is, however the series introduces 3 instances of
trailing whitespace (git complains) and few new tab characters (my
eyes do). Plus while building it (this time with gcc 3.4.6) i noticed
that the warnings around __put_user are gone, but lines 2746 and 2747
of op_helper.c produce (both originate from d9430add, which is also
yours):

warning: array subscript is above array bounds

Boils down to:

#define VSHIFT(suffix, leftp)                                           \
    void helper_vs##suffix (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)   \
    {                                                                   \
        int shift = b->u8[LO_IDX*0x15] & 0x7;                           \

I'd venture a guess that '*15' instead was meant to be there.

-- 
mailto:address@hidden