[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms |
Date: |
Mon, 18 May 2009 00:43:41 +0100 |
User-agent: |
KMail/1.11.2 (Linux/2.6.29-2-amd64; KDE/4.2.2; x86_64; ; ) |
> >> gplbios and vgabios are simple to build so it's where I started.
> >
> > This worries me. You've probably picked the easiest examples, and already
> > it doesn't fit nicely.
> >
> > Why are you trying so hard to integrate these into qemu? IMHO they really
> > don't belong there. AFAICS the roms share no significant code with qemu,
> > and require a completely different environment to build. Especially in
> > cross environments I'd expect combining the two to cause much more pain
> > than it's worth. When developing/building roms a native environment is
> > the exception rather than the norm. Even then it's not really a native
> > build, it's more a collection of hacks that allow you get away with using
> > a native toolchain.
>
> For any packager, it's absolutely necessary to build all of the
> distributed binaries from source.
I don't disagree with this.
> In general, QEMU does not support anything but lock-step versioning with
> it's ROMs. There is no ABI between QEMU and the BIOS.
This is obviously false for things like PXE roms.
> Having multiple packages therefore makes little sense because they can
> never be independent of each other.
Depends how your build system is setup. IMHO building a ROM and building qemu
itself are different tasks that effectively need separate packages anyway.
I also think that the Makefile is a bad place to encode knowledge of how to
build a rom. If roms are hard to build and configure, shouldn't we be fixing
that uptream? If not, isn't it going to be simpler and more effective to have
a script that fetches+builds all the roms we ship?
> As long as we include binaries in our source tree, I think we ought to
> also include the source for those binaries.
You aren't importing the source though. You're just add makefile hacks to
build it after it's been fetched from third party repositories.
Paul
- [Qemu-devel] [PATCH 4/4] Allow tool chain to be specified for bios build, (continued)
- [Qemu-devel] [PATCH 4/4] Allow tool chain to be specified for bios build, Anthony Liguori, 2009/05/17
- [Qemu-devel] [PATCH 2/4] Add submodule for VGABios, Anthony Liguori, 2009/05/17
- [Qemu-devel] [PATCH 3/4] Update makefile to build roms, Anthony Liguori, 2009/05/17
- [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms, Avi Kivity, 2009/05/17
- Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms, Paul Brook, 2009/05/17
- Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms, Anthony Liguori, 2009/05/17
- Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms,
Paul Brook <=
- Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms, Anthony Liguori, 2009/05/17
- Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms, Jamie Lokier, 2009/05/18
- Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms, Riku Voipio, 2009/05/18
- Re: [Qemu-devel] Re: [PATCH 3/4] Update makefile to build roms, Avi Kivity, 2009/05/18