[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] kvm: Mark full address range dirty on live migr
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH] kvm: Mark full address range dirty on live migration start |
Date: |
Sun, 24 May 2009 19:23:49 +0100 |
User-agent: |
KMail/1.11.2 (Linux/2.6.29-2-amd64; KDE/4.2.2; x86_64; ; ) |
On Saturday 23 May 2009, Glauber Costa wrote:
> On Fri, May 22, 2009 at 11:51:45PM +0200, Jan Kiszka wrote:
> > As Avi correctly noted, last_ram_offset does not mark the last physical
> > RAM address the guest may see (due to non-continuous memory regions).
> > Ensure that we catch them all by marking the full possible address range
> > dirty.
> >
> > Signed-off-by: Jan Kiszka <address@hidden>
>
> Indeed, we already do something in that lines in qemu-kvm tree,
> in a place that does not apply for It makes a lot of sense. Just
> maybe you could just -1UL instead of defining a new constant, but I don't
> really care.
-1ul is wrong. -1 is correct.
Paul