Re: [Qemu-devel] [PATCH 3/4] raw-posix: split hdev drivers

[Avi Kivity]

Christoph Hellwig wrote:
> Instead of declaring one BlockDriver for all host devices declared one
> for each type:  a generic one for normal disk devices, a Linux floppy
> driver and a CDROM driver for Linux and FreeBSD.  This gets rid of a lot
> of messy ifdefs and switching based on the type in the various removal
> device methods.
>
> block.c grows a new method to find the correct host device driver based
> on OS-sepcific criteria.  I would love to move this into some OS-dependant
> file but I don't think we have a place where it fits nicely yet.
>
>   

Add a ->probe_host_device() which accepts the filename (or maybe an fd) 
as a parameter.  First pass does a ->probe_host_device() for all drivers 
that support it, second pass tries ->probe().

btw, ->probe_host_device() should use ioctls to identify the device, not 
the device name, which is controlled by udev (on Linux) and therefore 
nonstandard.

--
error compiling committee.c: too many arguments to function