Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers

[Vincent Sanders]

On Sun, May 24, 2009 at 07:31:19PM +0100, Paul Brook wrote:
> On Saturday 23 May 2009, Vincent Sanders wrote:
> > On Thu, Apr 30, 2009 at 05:08:01PM +0100, Paul Brook wrote:
> > > >      env->cp15.c0_cpuid = id;
> > > >      switch (id) {
> > > > +    case ARM_CPUID_ARM920T:
> > > > +       break;
> > >
> > > This is woefully incomplete. At minimum it needs a comment describing how
> > > this is a lie.
> >
> > I have worked out what you meant was that the copro 15 registers
> > needed configuring appropriately in this case.
> 
> More fundamental than that. We emulate armv5te. The arm920t is armv4t.
> i.e. even usermode code may not work right.
> 

Thankyou, right, now I understand. Perhaps if you had been a little
more explicit in your first reply I would have been able to grasp what
you wanted sooner.

I will post the updated patch to the list shortly. Please be assured
that every program we have tried (boot loaders, Linux, BSD etc.)
appears to function as expected, to the point it had not been
apparient the 920 was a different ISA version to the default emulation.

So while this is indeed a technical issue, in practice it doesnt seem
to be a major problem. 

-- 
Regards Vincent