Re: [Qemu-devel] [PATCH] Call qemu_bh_delete at bdrv_aio_bh_cb

[Christoph Hellwig]

On Mon, Jun 01, 2009 at 12:10:02PM +0300, Dor Laor wrote:
> 

> >From 09ad82d8b8ebd1670aadf21eae8021dfad373c61 Mon Sep 17 00:00:00 2001
> From: Dor Laor <address@hidden>
> Date: Mon, 1 Jun 2009 12:07:23 +0300
> Subject: [PATCH] Call qemu_bh_delete at bdrv_aio_bh_cb.
>  Also replave qemu_bh_cancel with qemu_bh_delete in bdrv_aio_cancel_em.
>  Otherwise the bh will live forever in the bh list.

Looks good to me.  Those lifetime rules for QEMUBH objects look
quite awfull to me, though - but this whole don't directly free objects
but rather wait for $event (or forever) scheme seems pretty common in
qemu.