[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fix qemu_aio_flush
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH] fix qemu_aio_flush |
Date: |
Fri, 5 Jun 2009 17:57:39 +0200 |
User-agent: |
Mutt/1.3.28i |
On Thu, Jun 04, 2009 at 01:26:45PM +0200, Andrea Arcangeli wrote:
> Hello,
>
> Kevin has good point that when highlevel callback handler completes we
> should be guaranteed all underlying layers of callbacks events
> completed for that specific aio operation. So it seems the main bug
> was only in qemu_aio_flush() (only made visible by the debug code
> included in the ide_dma_cancel patch). I guess that's a problem for
> savevm/reset that assumes there is no outstanding aio waiting to be
> run while in fact there can be because of the bug. Patch is much
> simpler as seen below:
Yes, this looks better.