qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qdev: hook up i440fx pcihost to system bus.


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH] qdev: hook up i440fx pcihost to system bus.
Date: Mon, 8 Jun 2009 14:04:27 +0100
User-agent: KMail/1.11.4 (Linux/2.6.29-2-amd64; KDE/4.2.4; x86_64; ; )

> typedef struct {
> +    DeviceState qdev;
>...
>+static struct DeviceInfo i440fx_pcihost_devinfo = {
>+    .init = i440fx_initfn,
>+    .bus_type = BUS_TYPE_SYSTEM,
>+};

This is clearly a lie.

> +    s = container_of(qdev_create(NULL, "i440FX-pcihost"), I440FXState,

And this should be using FROM_SYSBUS.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]