|
From: | Uri Lublin |
Subject: | Re: [Qemu-devel] [PATCH] exec-migration: handle EINTR in popen_get_buffer() |
Date: | Tue, 09 Jun 2009 13:49:17 +0300 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 06/08/2009 07:55 PM, Blue Swirl wrote:
On 6/8/09, Uri Lublin<address@hidden> wrote:Sometimes, upon interrupt, fread returns with no data, and the (incoming exec) migration fails. Fix by retrying on such a case.Maybe a better solution would be to introduce qemu_{f,}{read,write}, which handle EINTR and partial reads/writes.
The migration code does not care about partial reads/writes (at this level). Data is read /written to/from a buffer. When needed/available we retry.
I can introduce qemu_{f,}{read,write} which only takes care of EINTR (by retrying) but the caller would have to handle partial reads/writes (and EAGAIN). Would that be helpful ?
Thanks, Uri.
[Prev in Thread] | Current Thread | [Next in Thread] |