Re: [Qemu-devel] Re: Networking patches queue

[Anthony Liguori]

Paul Brook wrote:
> On Tuesday 09 June 2009, Mark McLoughlin wrote:
>   
> >       net: add return value to packet receive handler (4f1c942b7f)
> >     
>
> This patch is wrong. We already have a can_receive handler for this purpose.  
> Having this callback and allowing receive to fail is just silly. One or the 
> other, but not both.
>   

How can can_receive fail for something like tap without actually trying 
to receive a packet?

If anything, we should just get rid of can_receive.

--
Regards,

Anthony Liguori