[Qemu-devel] Re: [PATCH 1/2] raw-posix: open flags use BDRV_ namespace, not posix namespace

[Christoph Hellwig]

On Tue, Jun 16, 2009 at 04:21:08PM +0300, Avi Kivity wrote:
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index 5032348..5790206 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -133,7 +133,7 @@ static int raw_open_common(BlockDriverState *bs, const 
> char *filename,
>      s->lseek_err_cnt = 0;
>  
>      s->open_flags |= O_BINARY;
> -    if ((flags & BDRV_O_ACCESS) == O_RDWR) {
> +    if ((flags & BDRV_O_ACCESS) == BDRV_O_RDWR) {
>          s->open_flags |= O_RDWR;
>      } else {
>          s->open_flags |= O_RDONLY;

Looks good.