Re: [Qemu-devel] [PATCH v4] avoid compilation warning/errors on up to date

[Anthony Liguori]

Jean-Christophe Dubois wrote:
> Once again, when all warnings are suppressed I doubt anybody will volunteer 
> for this boring task. And all future code added to the project without system 
> call error check will get unnoticed because you silenced GCC.
>
> But at the end it is your call.
>   

Silencing the warnings != fixing the warnings.

To fix the warning, the errors have to be dealt with in a graceful way.  
This means either propagating the errors and releases any acquired 
resources or aborting.

It is not an improvement to just add dummy error handling in a few 
spots.  It does not result in making the code any more robust.

Regards,

Anthony Liguori

> > Regards,
> >
> > Anthony Liguori
> >     
>
>