|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC |
Date: | Sat, 20 Jun 2009 15:46:30 -0500 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Avi Kivity wrote:
On 06/20/2009 05:31 PM, Anthony Liguori wrote:Please include a Signed-off-by line and use C-style comments instead of C++ style comments. Otherwise, looks good.What do we have against C++ style comments?
Just consistency: address@hidden:~/git/qemu$ grep '//' *.c | wc -l 163 address@hidden:~/git/qemu$ grep '/\*' *.c | wc -l 5642 Nothing personal. I think the kernel has a policy of C89 comments only. Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |