[Qemu-devel] Re: [PATCH 08/11] QMP: Port balloon command

[Avi Kivity]

On 06/23/2009 07:29 AM, Luiz Capitulino wrote:
>       else if (actual == 0)
> -        monitor_printf(mon, "Ballooning not activated in VM\n");
> +        monitor_printf_err(mon, "Ballooning not activated in VM\n");
>       else
> -        monitor_printf(mon, "balloon: actual=%d\n", (int)(actual>>  20));
> +        monitor_printf_data(mon, "balloon: actual=%d\n", (int)(actual>>  20));
>   }
>    

Control mode should always use bytes and seconds (and this should be 
described in the spec).  You avoid rounding, and more importantly, 
ambiguity and a source of unit conversion errors.

Patched that add a command to machine mode without updating the spec 
should be automatically NACKed.

We also need a way to discover that the command is available:

info commands
= info
= balloon
+ OK go for it

info command balloon
+ OK (no extensions yet)

--
error compiling committee.c: too many arguments to function