Re: [Qemu-devel] Re: [PATCH 08/11] QMP: Port balloon command

[Avi Kivity]

On 06/23/2009 04:59 PM, Anthony Liguori wrote:
> > Control mode should always use bytes and seconds (and this should be 
> > described in the spec).  You avoid rounding, and more importantly, 
> > ambiguity and a source of unit conversion errors.
>
>
> I'd actually like to see a lot more structure in this sort of output.  
> For instance:
>
> monitor_printf_list(mon, "balloon",
>                               "actual", MON_TIME, actual,
>                               NULL);
>
> How this gets output can then be conditional on control mode vs. human 
> mode.  In human mode, we can use human-friendly units like MBs.  In 
> control mode, we would always use bytes.

That actually works well with rpc.  You have a structure that contains 
the data.  For machine mode, you send that away.  For humans, you 
unit-convert, format and print.

> > Patched that add a command to machine mode without updating the spec 
> > should be automatically NACKed.
> >
> > We also need a way to discover that the command is available:
>
> I think we want to version each command too.

Not version, discover supported features.

--
error compiling committee.c: too many arguments to function