[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] qdev/compat: virtio-net-pci 0.10 compatibil
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] qdev/compat: virtio-net-pci 0.10 compatibility. |
Date: |
Thu, 9 Jul 2009 17:40:04 +0300 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Thu, Jul 09, 2009 at 03:02:33PM +0200, Gerd Hoffmann wrote:
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/pc.c | 4 ++++
> hw/virtio-pci.c | 13 ++++++++++++-
> 2 files changed, 16 insertions(+), 1 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 0b7c24b..ecb618d 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1471,6 +1471,10 @@ static QEMUMachine pc_machine_v0_10 = {
> .driver = "virtio-console-pci",
> .property = "class",
> .value = "0x0380", /* PCI_CLASS_DISPLAY_OTHER */
> + },{
> + .driver = "virtio-net-pci",
> + .property = "msi",
> + .value = "0",
> },
> { /* end of list */ }
> },
The number of vectors is part of hardware config so it's not a good idea
to use a binary property here. Since <= vectors is not a legal msi
configuration, it's enough to implement a "vectors" property instead:
virtio already interprets zero vectors as no msi. This also matches
command line/monitor syntax, which is a good thing.
Most virtio-net changes become then unnecessary.
--
MST
[Qemu-devel] [PATCH 1/5] qdev/compat: compat property infrastructure., Gerd Hoffmann, 2009/07/09
[Qemu-devel] [PATCH 2/5] qdev/compat: add pc-0.10 machine type., Gerd Hoffmann, 2009/07/09
[Qemu-devel] [PATCH 4/5] qdev/compat: virtio-balloon-pci 0.10 compatibility., Gerd Hoffmann, 2009/07/09
[Qemu-devel] [PATCH 5/5] qdev/compat: virtio-net-pci 0.10 compatibility., Gerd Hoffmann, 2009/07/09
- Re: [Qemu-devel] [PATCH 5/5] qdev/compat: virtio-net-pci 0.10 compatibility.,
Michael S. Tsirkin <=