[Qemu-devel] Re: [PATCH] Sparc32/PPC: convert escc to qdev

[Blue Swirl]

On 7/15/09, Juan Quintela <address@hidden> wrote:
> Blue Swirl <address@hidden> wrote:
>  > On 7/14/09, Juan Quintela <address@hidden> wrote:
>  >> Blue Swirl <address@hidden> wrote:
>
>
> I didn't explain myself enough, I guess.
>
>
>  >>  > +    qdev_set_prop_int(dev, "frequency", clock);
>
>                                    ^^^^^^^^^
>  ....
>
> >>  > +    clock = qdev_get_prop_int(&dev->qdev, "clock", 0);
>
>                                                   ^^^^^
>
>  You are setting a property named "frequency" and read a property named
>  "clock" :)  I just asked to use the same property in both places.

I see, thanks. Maybe an attempt to use an undeclared property should
raise an abort().