[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] rev5: support colon in filenames
From: |
Ram Pai |
Subject: |
Re: [Qemu-devel] [PATCH] rev5: support colon in filenames |
Date: |
Thu, 16 Jul 2009 00:39:27 -0700 |
On Wed, 2009-07-15 at 18:04 +0300, Blue Swirl wrote:
> On 7/15/09, Ram Pai <address@hidden> wrote:
> > Problem: It is impossible to feed filenames with the character colon because
> > qemu interprets such names as a protocol. For example filename scsi:0, is
> > interpreted as a protocol by name "scsi".
>
> > --- a/block/raw-posix.c
> > +++ b/block/raw-posix.c
> > +static int qemu_open(const char *filename, int flags, ...)
>
> > --- a/block/raw-win32.c
> > +++ b/block/raw-win32.c
> > + fd = qemu_open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
>
> I bet this won't compile on win32.
yes. good catch. fix is in the next revision(rev 6). However I do not
have a setup to compile and test changes in win32-raw.c . I will have to
rely on somebody to do the testing.
RP
- Re: [Qemu-devel] [PATCH] rev5: support colon in filenames, (continued)
- Re: [Qemu-devel] [PATCH] rev5: support colon in filenames, Gerd Hoffmann, 2009/07/16
- Re: [Qemu-devel] [PATCH] rev5: support colon in filenames, Kevin Wolf, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev5: support colon in filenames, Anthony Liguori, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev5: support colon in filenames, Paul Brook, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev5: support colon in filenames, Gerd Hoffmann, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev5: support colon in filenames, Paul Brook, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev5: support colon in filenames,
Ram Pai <=
- Re: [Qemu-devel] [PATCH] rev5: support colon in filenames, Kevin Wolf, 2009/07/16
- Re: [Qemu-devel] [PATCH] rev3: support colon in filenames, Jamie Lokier, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev3: support colon in filenames, Jan Kiszka, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev3: support colon in filenames, Jamie Lokier, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev3: support colon in filenames, Jan Kiszka, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev3: support colon in filenames, Jamie Lokier, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev3: support colon in filenames, Anthony Liguori, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev3: support colon in filenames, Jamie Lokier, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev3: support colon in filenames, Anthony Liguori, 2009/07/15
- Re: [Qemu-devel] [PATCH] rev3: support colon in filenames, Jamie Lokier, 2009/07/15