Re: [Qemu-devel] [PATCH, RFC] Sparc64: convert APB to qdev

[Igor Kovalenko]

On Mon, Jul 20, 2009 at 2:26 PM, Blue Swirl<address@hidden> wrote:
> I have a problem with APB conversion to qdev. For some reason, with
> the patch applied, PCI config register access changes and OpenBIOS
> can't find any PCI devices.

You are using pci_host_data_* which expects opaque pointer to PCIHostState,
so you need to pass appropriate opaque to cpu_register_io_memory.
With this small amendment I verified there are no changes to qemu.log and
serial console output.

Not sure if this requires sign-off :)

Signed-off-by: address@hidden

Index: qemu-trunk/hw/apb_pci.c
===================================================================
--- qemu-trunk.orig/hw/apb_pci.c
+++ qemu-trunk/hw/apb_pci.c
@@ -281,7 +281,7 @@ static void pci_pbm_init_device(SysBusDe
     sysbus_init_mmio(dev, 0x10ULL, pci_mem_config);
     /* mem_data */
     pci_mem_data = cpu_register_io_memory(pci_apb_read,
-                                          pci_apb_write, s);
+                                          pci_apb_write, &s->host_state);
     sysbus_init_mmio(dev, 0x10000000ULL, pci_mem_data);
 }



-- 
Kind regards,
Igor V. Kovalenko