[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/4] qdev/isa: add isa bus support to qdev.

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 1/4] qdev/isa: add isa bus support to qdev.
Date: Tue, 21 Jul 2009 09:11:06 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 07/17/09 20:12, Filip Navara wrote:
2009/7/15 Gerd Hoffmann<address@hidden>:
+static struct BusInfo isa_bus_info = {
+    .name  = "ISA",
+    .size  = sizeof(ISABus),
+    .props = (Property[]) {
+        {
+            .name   = "iobase",
+            .name   = "iobase2",

Why exactly two IO bases? That sounds like bad design to me. IMHO it
should be handled more like sysbus_init_mmio (or sysbus_init_mmio_cb)
and sysbus_mmio_map and the number of IO bases should be virtually
unlimited (something like QDEV_MAX_MMIO is acceptable).

Do we really need that? As new isa devices most likely wouldn't show up looking at the existing ones should give us a pretty complete picture ;)

Most devices use one iobase. A few (ide, ps/2) need two. Any devices which need more?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]