qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property typ


From: Gerd Hoffmann
Subject: [Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property type
Date: Tue, 21 Jul 2009 17:03:38 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 07/21/09 16:53, Anthony Liguori wrote:
Gerd Hoffmann wrote:
On 07/17/09 16:41, Anthony Liguori wrote:

Signed-off-by: Anthony Liguori<address@hidden>

Hmm, I think that goes into the wrong direction. Properties should not
be pointers to internal qemu state. Yes, there is qemu_prop_ptr, but I
consider that a temporary stopgap until we can do better.
Instead CharDriverState's should get a name and we need a way to
lookup them by name. Then we can store the name instead of a pointer
into the property.

Would you have a property type that was basically a char driver state name?

Yes. Same for drives and others. A generic string property should do I think.

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]