[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] configure: fix breakage of --extra-{cflags, ld
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH] configure: fix breakage of --extra-{cflags, ldflags} |
Date: |
Thu, 23 Jul 2009 16:13:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Nathan Froyd wrote:
> Commit e3fc14c3a1a77a1cda669a3e16f1f6b82577e4ec broke the use of
> --extra-{cflags,ldflags} in the case where those flags were necessary
> for bits of configure to succeed. For instance, if you did:
>
> configure [...] --extra-cflags=-I/path/to/zlib/headers \
> --extra-ldflags=-L/path/to/zlib/libraries
>
> prior to the above commit, the paths would go into CFLAGS and LDFLAGS
> for use by the rest of the configure tests. After the above commit,
> that's no longer true, because the EXTRA_{CFLAGS,LDFLAGS} variables are
> only used for creating makefiles.
Yep, that's true...
>
> Fixed by making sure that EXTRA_{CFLAGS,LDFLAGS} find their way into
> {CFLAGS,LDFLAGS}, respectively.
>
> Signed-off-by: Nathan Froyd <address@hidden>
> ---
> configure | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 0db885b..dd2b1d9 100755
> --- a/configure
> +++ b/configure
> @@ -520,8 +520,8 @@ CFLAGS="$CFLAGS -g -fno-strict-aliasing"
> if test "$debug" = "no" ; then
> CFLAGS="$CFLAGS -O2"
> fi
> -CFLAGS="$CFLAGS -Wall -Wundef -Wendif-labels -Wwrite-strings
> -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls"
> -LDFLAGS="$LDFLAGS -g"
> +CFLAGS="$CFLAGS $EXTRA_CFLAGS -Wall -Wundef -Wendif-labels -Wwrite-strings
> -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls"
> +LDFLAGS="$LDFLAGS $EXTRA_LDFLAGS -g"
...but now we add the extra flags twice. So please remove the injection
into the flags for $config_mak.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
Re: [Qemu-devel] [PATCH] configure: fix breakage of --extra-{cflags, ldflags}, Nathan Froyd, 2009/07/23