|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] Re: [PATCH 3/4] Use C99 initializers for audio_option |
Date: | Tue, 28 Jul 2009 10:03:53 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 07/28/09 00:20, Juan Quintela wrote:
malc<address@hidden> wrote:On Mon, 27 Jul 2009, Juan Quintela wrote: I'd prefer: { .name = "DAC_SIZE_IN_USEC", .tag = AUD_OPT_BOOL, .valp =&conf.size_in_usec_out, .descr = "DAC period/buffer size in microseconds (otherwise in frames)" }, { ... And likewise elsewhere.I tried to be consistent with the qdev patches, they add all its "arrays of structures" this way (it is one of the bigger users of the feature that I saw).
I think malc refers to the vertical alignment, i.e. .foo = bar, .longname = somethingelse, instead of .foo = bar, .longname = somethingelse, The version with the vertical aligned '=' is more readable IMO. cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |