On 07/27/2009 08:47 PM, Beth Kon wrote:
Hi Jes. These bios changes rely on matching userspace/kernel changes
that translate irq0->inti2. So assuming seabios is used for systems
other than kvm and qemu, this code would need to be conditionally
removed.
Hi Beth,
Thanks for the input. I guess we'll want it to be CONFIG_KVM for now
then, since Seabios doesn't know of BX_QEMU. Once we have more of the
cfg_fw stuff needed for this, the #ifdef part can be made prettier.
But I'm not clear on what you're doing with this patch. You didn't
include the irq0override flag that is needed by kvm because there are
circumstances under which kvm turns off irq0override (i.e., old kernels
that don't support irq routing). So this patch is fine for qemu, since
it is permanently enabled there, but it is not a permanent solution for
kvm.
The reason I didn't include the irq0override flag is that the fw_cfg
bits for this aren't in Seabios yet. I'll be happy to add them in a
follow up patch.
How do you like this version? It's a little more complex as I introduced
the irq0override variable, but it will make it very easy to add the
cfg_fw stuff.
Cheers,
Jes