[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/25] Introduce QEMU dictionary data type
From: |
malc |
Subject: |
Re: [Qemu-devel] [PATCH 01/25] Introduce QEMU dictionary data type |
Date: |
Wed, 29 Jul 2009 17:38:11 +0400 (MSD) |
On Wed, 29 Jul 2009, Luiz Capitulino wrote:
> On Wed, 29 Jul 2009 02:39:03 +0400 (MSD)
> malc <address@hidden> wrote:
>
> > On Tue, 28 Jul 2009, Luiz Capitulino wrote:
> >
> > > A dictionary is a high-level data type used to store a collection of
> > > values, where a unique key is associated with one value. Usually, the
> > > notation 'key:value' is used to denote this relationship.
> > > +
> > > +/**
> > > + * __qemu_dict_get(): Low-level lookup function
> > > + */
> > > +static void *__qemu_dict_get(const struct qemu_dict *qdict,
> > > + const char *key, unsigned int hash)
> >
> > Do not violate the standard please.
>
> What's the problem, the '__' or the indentation?
Double underscore.
>
> > [..snip..]
> >
> > > @@ -0,0 +1,36 @@
> > > +#ifndef __QEMU_DICT_H__
> > > +#define __QEMU_DICT_H__
> >
> > Ditto.
>
> Will fix.
>
--
mailto:address@hidden
- [Qemu-devel] [PATCH 00/25] Monitor handlers new structure phase 1, Luiz Capitulino, 2009/07/28
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Avi Kivity, 2009/07/29
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Anthony Liguori, 2009/07/29
- Re: [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Avi Kivity, 2009/07/29
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Luiz Capitulino, 2009/07/29
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Avi Kivity, 2009/07/29
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Luiz Capitulino, 2009/07/29
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Avi Kivity, 2009/07/29
- [Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type, Luiz Capitulino, 2009/07/29