[Qemu-devel] Re: [PATCH 01/25] Introduce QEMU dictionary data type

[Luiz Capitulino]

On Thu, 30 Jul 2009 18:03:55 +0300
Avi Kivity <address@hidden> wrote:

> On 07/30/2009 05:50 PM, Luiz Capitulino wrote:
>
> >   A last comment. My patches introduce explicit casting, as in:
> >
> > int index = (long) qemu_dict_get(qdict, "index");
> >
> >   Although the current code doesn't do that, it passes the
> > 'arg[]' contents to handlers, I *guess* the compiler will
> > do the same kind of casting will apply.
> >    

s/will apply// :)

> So the existing code splits 64-bit types into two 32-bit values.  As 
> long as you do the same (for now), we should be safe.

 Yes, I already do the same. I have changed some 'int's to 'long's
for no reason though, will fix that (but should not be a problem,
anyway).

> Later of course we can replace it with a QNumber or QInteger.

 Exactly.